[wesnoth-commits] [wesnoth/wesnoth] 5ab41e: fs: Un-inline non-trivial blacklist_pattern_list m...

[Iris Morelle]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5ab41ee9f9e4ec39a1c4c1111d04ae027d25a097
      https://github.com/wesnoth/wesnoth/commit/5ab41ee9f9e4ec39a1c4c1111d04ae027d25a097
  Author: Iris Morelle <shadowm at wesnoth.org>
  Date:   2020-12-04 (Fri, 04 Dec 2020)

  Changed paths:
    M src/build_info.cpp
    M src/filesystem.cpp
    M src/filesystem.hpp
    M src/filesystem_common.cpp
    M src/gettext.cpp

  Log Message:
  -----------
  fs: Un-inline non-trivial blacklist_pattern_list methods

This allows us to drop the hard dependency on <algorithm>, <functional>,
and serialization/string_utils.hpp from filesystem.hpp, which should
make the latter less of a heavyweight include in places that otherwise
don't need those headers.

There are no performance concerns here because the class as a whole is
rarely used in general and never in performance-sensitive code.

This commit also addresses a few side-effects of other files
piggybacking on the filesystem.hpp dependencies.