[wesnoth-commits] [wesnoth/wesnoth] 0380d6: GUI2: initial work to remove window reference bind...

[Charles Dang]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 0380d634fd555092ac795575f49042c6b62c913c
      https://github.com/wesnoth/wesnoth/commit/0380d634fd555092ac795575f49042c6b62c913c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2020-11-22 (Sun, 22 Nov 2020)

  Changed paths:
    M src/gui/dialogs/addon/connect.cpp
    M src/gui/dialogs/addon/connect.hpp
    M src/gui/dialogs/campaign_selection.cpp
    M src/gui/dialogs/campaign_selection.hpp
    M src/gui/dialogs/core_selection.cpp
    M src/gui/dialogs/core_selection.hpp
    M src/gui/dialogs/game_stats.cpp
    M src/gui/dialogs/game_stats.hpp
    M src/gui/dialogs/game_version_dialog.cpp
    M src/gui/dialogs/game_version_dialog.hpp
    M src/gui/dialogs/help_browser.cpp
    M src/gui/dialogs/help_browser.hpp
    M src/gui/dialogs/multiplayer/faction_select.cpp
    M src/gui/dialogs/multiplayer/faction_select.hpp
    M src/gui/dialogs/server_info_dialog.cpp
    M src/gui/dialogs/server_info_dialog.hpp
    M src/gui/dialogs/statistics_dialog.cpp
    M src/gui/dialogs/statistics_dialog.hpp
    M src/gui/dialogs/unit_advance.cpp
    M src/gui/dialogs/unit_advance.hpp
    M src/gui/dialogs/unit_attack.cpp
    M src/gui/dialogs/unit_attack.hpp
    M src/gui/dialogs/unit_create.cpp
    M src/gui/dialogs/unit_create.hpp
    M src/gui/dialogs/unit_list.cpp
    M src/gui/dialogs/unit_list.hpp
    M src/gui/dialogs/unit_recall.cpp
    M src/gui/dialogs/unit_recall.hpp
    M src/gui/dialogs/unit_recruit.cpp
    M src/gui/dialogs/unit_recruit.hpp

  Log Message:
  -----------
  GUI2: initial work to remove window reference bindings in dialog callbacks

This practice stems from a time before get_window() was available in modal_dialog so the window reference
*had* to be bound to any callback that wanted to use it, resulting in a mess. This is much cleaner.