[wesnoth-commits] [wesnoth/wesnoth] e9603e: Show the "loyal" trait in help (#5123)

[Steve Cotton]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: e9603e6e010a99eb08e76d41b24baa63928a5153
      https://github.com/wesnoth/wesnoth/commit/e9603e6e010a99eb08e76d41b24baa63928a5153
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2020-09-11 (Fri, 11 Sep 2020)

  Changed paths:
    M src/help/help_impl.cpp
    M src/help/help_impl.hpp

  Log Message:
  -----------
  Show the "loyal" trait in help (#5123)

Fixes #1935 for normal users, expanding on aac0941's fix which only showed
these abiities when Wesnoth was in debug mode.

The removed enum member "NON_REVEALING_DESCRIPTION" was unused, and all
existing callers effectively used description_type() as a boolean.

This does mean that the "aged" trait will be shown to all users, even if
they haven't played HttT, however that seems reasonable.