[wesnoth-commits] [wesnoth/wesnoth] bf153a: Fixed difficulty selection popping up multiple tim...

[Charles Dang]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: bf153a1f762d5ce33b17994960b232df459d4a45
      https://github.com/wesnoth/wesnoth/commit/bf153a1f762d5ce33b17994960b232df459d4a45
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-16 (Sat, 16 Jan 2021)

  Changed paths:
    M changelog.md
    M src/savegame.cpp

  Log Message:
  -----------
  Fixed difficulty selection popping up multiple times when loading a game (fixes #5392)

The first issue was difficulty_dialog::show being called twice. The second issue was that show_difficulty_dialog
was called from both load_game_ingame and load_game. The latter is called after the former (this should probably
be refactored), so if you selected Change Difficulty when loading from within a game, the dialog prompt would be
shown when both functions were called. Fixed this by toggling off the show_difficulty flag once a difficulty had
been selected.


  Commit: e2e50645cdcead189a096f82a3dc54a1bd662477
      https://github.com/wesnoth/wesnoth/commit/e2e50645cdcead189a096f82a3dc54a1bd662477
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-01-16 (Sat, 16 Jan 2021)

  Changed paths:
    M data/campaigns/Dead_Water/_main.cfg
    M data/campaigns/Dead_Water/units/Kraken.cfg

  Log Message:
  -----------
  DW: ditch the ENABLE_KRAKEN macro


Compare: https://github.com/wesnoth/wesnoth/compare/f69aa281c16b...e2e50645cdce