[wesnoth-commits] [wesnoth/wesnoth] 5c54b6: Remove remnants of rooms.

[Pentarctagon]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5c54b6bdfd03958caef2d522d38a7daa269dbe7b
      https://github.com/wesnoth/wesnoth/commit/5c54b6bdfd03958caef2d522d38a7daa269dbe7b
  Author: Pentarctagon <pentarctagon at tutamail.com>
  Date:   2021-06-18 (Fri, 18 Jun 2021)

  Changed paths:
    M src/game_initialization/lobby_data.cpp
    M src/game_initialization/lobby_data.hpp
    M src/game_initialization/lobby_info.cpp
    M src/game_initialization/lobby_info.hpp
    M src/gui/dialogs/multiplayer/lobby.cpp
    M src/gui/dialogs/multiplayer/lobby.hpp

  Log Message:
  -----------
  Remove remnants of rooms.


  Commit: 7fa4b92faf3cc0ea273c990f007e1170d02af935
      https://github.com/wesnoth/wesnoth/commit/7fa4b92faf3cc0ea273c990f007e1170d02af935
  Author: Pentarctagon <pentarctagon at tutamail.com>
  Date:   2021-06-18 (Fri, 18 Jun 2021)

  Changed paths:
    M src/gui/dialogs/multiplayer/lobby.cpp

  Log Message:
  -----------
  Remove unused code.


  Commit: dc813ac693cf2eee1dc27539306a8cf6ce9c2945
      https://github.com/wesnoth/wesnoth/commit/dc813ac693cf2eee1dc27539306a8cf6ce9c2945
  Author: Pentarctagon <pentarctagon at tutamail.com>
  Date:   2021-06-18 (Fri, 18 Jun 2021)

  Changed paths:
    M data/advanced_preferences.cfg
    M src/gui/dialogs/multiplayer/lobby.cpp
    M src/preferences/lobby.cpp
    M src/preferences/lobby.hpp

  Log Message:
  -----------
  Remove the 'group players' lobby UI preference.


  Commit: 0e3faee8031610a1e7db2cd484e4c65cfbe292ea
      https://github.com/wesnoth/wesnoth/commit/0e3faee8031610a1e7db2cd484e4c65cfbe292ea
  Author: Pentarctagon <pentarctagon at tutamail.com>
  Date:   2021-06-18 (Fri, 18 Jun 2021)

  Changed paths:
    M src/gui/dialogs/multiplayer/lobby.cpp
    M src/gui/dialogs/multiplayer/lobby.hpp
    M src/gui/widgets/tree_view.cpp
    M src/gui/widgets/tree_view.hpp
    M src/gui/widgets/tree_view_node.cpp
    M src/gui/widgets/tree_view_node.hpp

  Log Message:
  -----------
  Add a method to clear and then add multiple items to a tree view.

This addresses the lobby performance issue as far as the playerlist updating. Previously for every player an item was added and the size of the tree view recalculated, which led to an increasingly unresponsive UI when the number of players in the lobby got to around 150+. With this change, the replace_children() method adds all the players and then after that recalculates the tree view's size once.


Compare: https://github.com/wesnoth/wesnoth/compare/4511512c501c...0e3faee80316