[wesnoth-commits] [wesnoth/wesnoth] 1d0b24: Cleaned up about::get_campaign_credits usage

[Charles Dang]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 1d0b245504991013eb92f03941cbc255e009e41b
      https://github.com/wesnoth/wesnoth/commit/1d0b245504991013eb92f03941cbc255e009e41b
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-06-28 (Mon, 28 Jun 2021)

  Changed paths:
    M src/about.cpp
    M src/about.hpp
    M src/gui/dialogs/outro.cpp

  Log Message:
  -----------
  Cleaned up about::get_campaign_credits usage


  Commit: fb35023814111b367c1bb66ce96f0a160ec3e6f7
      https://github.com/wesnoth/wesnoth/commit/fb35023814111b367c1bb66ce96f0a160ec3e6f7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-06-28 (Mon, 28 Jun 2021)

  Changed paths:
    M src/gui/dialogs/editor/generator_settings.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/widgets/status_label_helper.hpp

  Log Message:
  -----------
  GUI2: cleaned up and improved up bind_status_label implementation

- Used constexpr if instead of SFINAE for the default getter functions
- Added support for menu buttons in the default getter function
- Fixes potentially calling get_value_label on classes derived from integer_selector other than slider
  (this function is a member of the slider class)
- Made value getters take a const reference (we don't want to be able to modify widgets here)
- Made value getters return a t_string (avoids conversion to std::string and set_label takes a t_string anyway)


  Commit: 84f71d1b713a4053efe15c0f9e84948564835a9f
      https://github.com/wesnoth/wesnoth/commit/84f71d1b713a4053efe15c0f9e84948564835a9f
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-06-28 (Mon, 28 Jun 2021)

  Changed paths:
    M src/gui/widgets/helper.cpp

  Log Message:
  -----------
  GUI2: made static map const in decode_font_style


  Commit: ee5e159ce4538ff2dcc01debe81566ce91ce970f
      https://github.com/wesnoth/wesnoth/commit/ee5e159ce4538ff2dcc01debe81566ce91ce970f
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2021-06-28 (Mon, 28 Jun 2021)

  Changed paths:
    M src/utils/general.hpp

  Log Message:
  -----------
  Utils: decay both types passed to decayed_is_same


Compare: https://github.com/wesnoth/wesnoth/compare/da6a6f31d9db...ee5e159ce453