[wesnoth-commits] [wesnoth/wesnoth] 13bc06: Remove the old PNG optimisation script

Steve Cotton noreply at github.com
Fri May 7 10:02:23 UTC 2021


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 13bc062975894a68d065593658ce5ae33f6d34e7
      https://github.com/wesnoth/wesnoth/commit/13bc062975894a68d065593658ce5ae33f6d34e7
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2021-05-07 (Fri, 07 May 2021)

  Changed paths:
    M changelog.md
    R utils/indexed2rgb.sh
    R utils/wesnoth-optipng

  Log Message:
  -----------
  Remove the old PNG optimisation script

A Python version was added in b3fe980d709add4fb8b3fb88faad946bfe55e477, the
main reason for removing the old one is that it's inconsistent to have two
tools where one does almost (but not quite) the same as the other.

Both versions check that the old and new images look the same. However, if any
tool changed the pixels' values then old script would discard the changes from
the other tools too. The new script checks the image after each tool is run, so
that the optimisations from the other tools can still be kept.

The indexed2rgb.sh script had a call to utils/wesnoth-optipng. It's deleted
instead of updated because both wesnoth-optipng itself (since 17c242a9f) and
the new woptipng both do what indexed2rgb.sh did (they all run ImageMagick with
option "png:color-type=6").





More information about the Commits mailing list