[wesnoth-commits] [wesnoth/wesnoth] b6225e: Make callers of help::show_help not need a help_ma...

[Steve Cotton]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: b6225e354daf48e8adb563078d52f8b588d64486
      https://github.com/wesnoth/wesnoth/commit/b6225e354daf48e8adb563078d52f8b588d64486
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2021-05-14 (Fri, 14 May 2021)

  Changed paths:
    M src/gui/dialogs/multiplayer/faction_select.cpp
    M src/gui/dialogs/multiplayer/lobby.cpp
    M src/gui/dialogs/title_screen.cpp
    M src/help/help.cpp
    M src/help/help.hpp
    M src/scripting/lua_gui2.cpp

  Log Message:
  -----------
  Make callers of help::show_help not need a help_manager

Most of the places that created a help_manager did so just to call show_help on
the next line. Move knowledge of the internals out of those callers and into
help.cpp.

This leaves editor_controller and play_controller with knowledge of help_manager,
however both of those classes handle ownership of the game_config too.