[wesnoth-commits] [wesnoth/wesnoth] 13c5d8: Disable the fast path of [modify_unit] (#6222)

[Steve Cotton]

  Branch: refs/heads/1.16
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 13c5d8a96ead8d2a7f0435f60b8ec7f7e0af0972
      https://github.com/wesnoth/wesnoth/commit/13c5d8a96ead8d2a7f0435f60b8ec7f7e0af0972
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2021-10-23 (Sat, 23 Oct 2021)

  Changed paths:
    M data/lua/wml/modify_unit.lua
    A data/test/scenarios/test_modify_unit.cfg
    M wml_test_schedule

  Log Message:
  -----------
  Disable the fast path of [modify_unit] (#6222)

With these two lists emptied, is_simple() will always return false, and the
code will always use the slow path. The slow path is slow because it stores and
unstores the unit, triggering the desired side effects of unstoring a unit.

Fixes issue #5133, and tests that with the new unit test.

Fixes bug #4978, that changing the facing wasn't updating the display.