[wesnoth-commits] [wesnoth/wesnoth] 1014fd: Switch to hard-coded colours instead of relying on...

[Wedge009]

  Branch: refs/heads/1.16
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 1014fd174101419a36b913ac5bd0255c5f0e98b4
      https://github.com/wesnoth/wesnoth/commit/1014fd174101419a36b913ac5bd0255c5f0e98b4
  Author: Wedge009 <wedge009 at wedge009.net>
  Date:   2021-09-20 (Mon, 20 Sep 2021)

  Changed paths:
    M src/help/help_impl.cpp
    M src/reports.cpp
    M src/units/attack_type.cpp
    M src/units/unit.cpp

  Log Message:
  -----------
  Switch to hard-coded colours instead of relying on pango names (resolves #4348).

* Pango changed its definition of 'green' in version 1.32.2 to align with CSS specifications (see #4348 for details).
* This change focuses only on instances of '<span color="green">', leaving instances of named colours that don't use 'green'.
* Problem: Cannot use this approach with '<format>' (at least not that I'm currently aware) so it breaks time-of-day bonus colour consistency.

(cherry picked from commit 57cfcf87d79de2f6c06a27f1938021971d7310e0)


  Commit: 6b1de3bc1d52977d67a0276b4ab55c2769deaa78
      https://github.com/wesnoth/wesnoth/commit/6b1de3bc1d52977d67a0276b4ab55c2769deaa78
  Author: Wedge009 <wedge009 at wedge009.net>
  Date:   2021-09-20 (Mon, 20 Sep 2021)

  Changed paths:
    M src/gui/dialogs/formula_debugger.cpp

  Log Message:
  -----------
  Switch to hard-coded colours for formula debugger as well.

(cherry picked from commit 8285cac7f5fa182dcfae5b592626e601042eefe5)


  Commit: fd91907e188fb17a85c7f1ecca21f18e11a891e2
      https://github.com/wesnoth/wesnoth/commit/fd91907e188fb17a85c7f1ecca21f18e11a891e2
  Author: Wedge009 <wedge009 at wedge009.net>
  Date:   2021-09-20 (Mon, 20 Sep 2021)

  Changed paths:
    M src/reports.cpp

  Log Message:
  -----------
  Link side-bar unit defence rating to unit's Help page (resolves #1297).

(cherry picked from commit daabe2d183cbf630275b47f0350bd5c3288f7748)


Compare: https://github.com/wesnoth/wesnoth/compare/8d2171df2644...fd91907e188f