[wesnoth-commits] [wesnoth/wesnoth] 650f70: fix [firststrike] special with apply_to=opponent c...

[newfrenchy83]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 650f70405fffbe60648f24f8dce061575d689538
      https://github.com/wesnoth/wesnoth/commit/650f70405fffbe60648f24f8dce061575d689538
  Author: newfrenchy83 <31768074+newfrenchy83 at users.noreply.github.com>
  Date:   2022-04-08 (Fri, 08 Apr 2022)

  Changed paths:
    A data/test/maps/4p_single_castle.map
    A data/test/scenarios/firststrike_and_laststrike.cfg
    A data/test/scenarios/poison_opponent.cfg
    M src/units/abilities.cpp
    M wml_test_schedule

  Log Message:
  -----------
  fix [firststrike] special with apply_to=opponent crashes Wesnoth 1.17.x (#6574)

As reported on the forum in https://forums.wesnoth.org/viewtopic.php?p=672374#p672374
If a unit with "last strike" ([firststrike] special with apply_to=opponent, on any of its attacks)
was targeted by other unit for attack, wesnoth crashed.

Fix similar problems for other weapon specials like poisons, when two users of specials with
apply_to=opponent fought, one fighter only could be poisoned or slowed.

* Add a unit test for poison
* Add a unit test for firststrike and laststrike