[wesnoth-commits] [wesnoth/wesnoth] 6ccac5: Change [filter_weapon] to not depend on attack_typ...

[Steve Cotton]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 6ccac5a5e8ff75303c9190c0da60580925cb32c0
      https://github.com/wesnoth/wesnoth/commit/6ccac5a5e8ff75303c9190c0da60580925cb32c0
  Author: Steve Cotton <steve at octalot.co.uk>
  Date:   2022-02-10 (Thu, 10 Feb 2022)

  Changed paths:
    M src/formula/callable_objects.cpp

  Log Message:
  -----------
  Change [filter_weapon] to not depend on attack_type::weapon_specials

This changes it to use the function that attack_type::get_value already uses,
thus removing a call to attack_type::weapon_specials. The latter is being
refactored by newfrenchy83, and questions about the effect of that refactor on
this code delayed the review on his PR.

This code is part of the object used for [filter_weapon]formula=, however the
implementation of that filter creates exactly one attack_type_callable, so
doesn't trigger this code. For testing I called it via a debugger.