[Commits] [wesnoth/wesnoth] e28bda: check lobby_sounds preference for the GUI 1 lobby ...

GitHub noreply at github.com
Mon Jul 14 06:13:01 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: e28bda277aa9630daae8103084ed0e3ae3848b89
      https://github.com/wesnoth/wesnoth/commit/e28bda277aa9630daae8103084ed0e3ae3848b89
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-07-14 (Mon, 14 Jul 2014)

  Changed paths:
    M src/multiplayer_ui.cpp

  Log Message:
  -----------
  check lobby_sounds preference for the GUI 1 lobby also

This fixes a bug reported on forums here:
http://forums.wesnoth.org/viewtopic.php?f=4&t=40660#p572131

The lobby sounds pref now affects the GUI 1 and 2 mp lobbies,
but it only affects the lobby screen, not mp::wait or mp::connect
etc.

This check is implemented by trying to dynamic cast 'this' mp::ui
object to a mp::lobby, at the time when we would play the arrive
or leave sounds.

The lobby sounds pref does *not* block the sounds due to server
messages, messages from a friend, or whispers.


  Commit: 7d22ffb089708397c3058f5e8eb08b205585c590
      https://github.com/wesnoth/wesnoth/commit/7d22ffb089708397c3058f5e8eb08b205585c590
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-07-14 (Mon, 14 Jul 2014)

  Changed paths:
    M changelog

  Log Message:
  -----------
  update changelog


Compare: https://github.com/wesnoth/wesnoth/compare/edaafcb1cf99...7d22ffb08970


More information about the Commits mailing list