[Commits] [wesnoth/wesnoth] 1c0323: Fix using an uninitialised value.

[GitHub]

  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 1c0323c7934b501d46240455fbfb76c604479f11
      https://github.com/wesnoth/wesnoth/commit/1c0323c7934b501d46240455fbfb76c604479f11
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-03-08 (Sat, 08 Mar 2014)

  Changed paths:
    M src/game_events/action_wml.cpp

  Log Message:
  -----------
  Fix using an uninitialised value.

While using valgrind to investigate bug #20876 it warned about this
issue.

Ported from a6eeac04e5dc863013fa3e5e0b723825ddc4fc08


  Commit: 5d66e928a3e881f12460ba0263e80421a1787615
      https://github.com/wesnoth/wesnoth/commit/5d66e928a3e881f12460ba0263e80421a1787615
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-03-08 (Sat, 08 Mar 2014)

  Changed paths:
    M src/image_modifications.cpp

  Log Message:
  -----------
  Make sure cut_surface gets a neutral surface.

Also change its return to an optimised surface. Fixes bug #20876.

>From the comment added to the source:
Unlike other image functions cut_surface does not convert the input
surface to a neutral surface, nor does it convert its return surface
to an optimised surface.

Since it seems to work for most cases, rather change this caller instead
of the function signature. (The issue was discovered in bug #20876).


  Commit: 7c284d05f8faaa2c7a2841b0ceb0a5296a966846
      https://github.com/wesnoth/wesnoth/commit/7c284d05f8faaa2c7a2841b0ceb0a5296a966846
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-03-08 (Sat, 08 Mar 2014)

  Changed paths:
    M src/game_events/action_wml.cpp
    M src/image_modifications.cpp

  Log Message:
  -----------
  Merge branch 'bug_20876' into 1.12

Fixes bug #20876.


Compare: https://github.com/wesnoth/wesnoth/compare/8a6572368d0c...7c284d05f8fa