[Commits] [wesnoth/wesnoth] a6eeac: Fix using an uninitialised value.

GitHub noreply at github.com
Sat Mar 8 09:31:11 UTC 2014


  Branch: refs/heads/1.10
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a6eeac04e5dc863013fa3e5e0b723825ddc4fc08
      https://github.com/wesnoth/wesnoth/commit/a6eeac04e5dc863013fa3e5e0b723825ddc4fc08
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-03-08 (Sat, 08 Mar 2014)

  Changed paths:
    M src/game_events.cpp

  Log Message:
  -----------
  Fix using an uninitialised value.

While using valgrind to investigate bug #20876 it warned about this
issue.


  Commit: ba0cec8acbf70483e634fb050dfed40b05ed2f8e
      https://github.com/wesnoth/wesnoth/commit/ba0cec8acbf70483e634fb050dfed40b05ed2f8e
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-03-08 (Sat, 08 Mar 2014)

  Changed paths:
    M src/image_modifications.cpp

  Log Message:
  -----------
  Make sure cut_surface gets a neutral surface.

Also change its return to an optimised surface. Fixes bug #20876.

>From the comment added to the source:
Unlike other image functions cut_surface does not convert the input
surface to a neutral surface, nor does it convert its return surface
to an optimised surface.

Since it seems to work for most cases, rather change this caller instead
of the function signature. (The issue was discovered in bug #20876).


  Commit: e83eb4537f5c364adb9d02fba245eceab3b5f727
      https://github.com/wesnoth/wesnoth/commit/e83eb4537f5c364adb9d02fba245eceab3b5f727
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2014-03-08 (Sat, 08 Mar 2014)

  Changed paths:
    M changelog

  Log Message:
  -----------
  Update changelog.


Compare: https://github.com/wesnoth/wesnoth/compare/adf0869fd27b...e83eb4537f5c


More information about the Commits mailing list