[Commits] [wesnoth/wesnoth] acafb9: style.css,html.py: use <pre> instead of <br/>; re....

GitHub noreply at github.com
Mon May 5 08:22:56 UTC 2014


  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: acafb98bde3102c11381d50648982319ece9d14f
      https://github.com/wesnoth/wesnoth/commit/acafb98bde3102c11381d50648982319ece9d14f
  Author: Groggy Dice <groggydice at yahoo.com>
  Date:   2014-05-05 (Mon, 05 May 2014)

  Changed paths:
    M data/tools/addon_manager/html.py
    M data/tools/addon_manager/style.css

  Log Message:
  -----------
  style.css,html.py: use <pre> instead of <br/>; re.sub instead of re.finditer

After looking into it some more, I think I've figured out how to handle <pre>
in the CSS. So, use that, when description has more than one line.

Also, go to re.sub for turning URLs into links. The version of Python I was
testing my code on wasn't properly handling backreferences in the replacement
string when in the form "\#", causing me to use finditer instead of sub. But
I've discovered that it does handle backreferences in the form "\g<#>". So
switch to much simpler re.sub code.


  Commit: a08fe82f2a4c3e493a699ca0a1dd4c47d6eb58a8
      https://github.com/wesnoth/wesnoth/commit/a08fe82f2a4c3e493a699ca0a1dd4c47d6eb58a8
  Author: Groggy Dice <groggydice at yahoo.com>
  Date:   2014-05-05 (Mon, 05 May 2014)

  Changed paths:
    M data/tools/addon_manager/html.py

  Log Message:
  -----------
  html.py: replace Windows backslashes in icon paths

This is one source of missing-image results.

There remain other reasons for missing icons. The script doesn't find images
in add-ons. And when resources are moved or renamed, they are no longer found
by the script, even if they had been found before.

Also, capitalize a sentence.


Compare: https://github.com/wesnoth/wesnoth/compare/2ef589480061...a08fe82f2a4c


More information about the Commits mailing list