[Commits] [wesnoth/wesnoth] 243ab0: fixup gui2 unit tests

[GitHub]

  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 243ab0a1541ad0a9fad8235efea867b19e5aa8a0
      https://github.com/wesnoth/wesnoth/commit/243ab0a1541ad0a9fad8235efea867b19e5aa8a0
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-13 (Tue, 13 May 2014)

  Changed paths:
    M src/tests/gui/test_gui2.cpp

  Log Message:
  -----------
  fixup gui2 unit tests

The file test_gui2.cpp was causing segfaults in the debug build,
gfgtdf spotted the cause: a function was returning references to
local variables. It was most likely a minor oversight, as many
similar functions nearby made these variables static. This commit
makes those local variables static and appears to fix the crash.

Relevant irc chat: http://www.wesnoth.org/irclogs/2014/05/%23wesnoth-dev.2014-05-13.log