[Commits] [wesnoth/wesnoth] 314425: fs: Use game data path to resolve ./ in the absenc...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 314425ab0e57b32909d324f7d4bf213d62cbd3b5
      https://github.com/wesnoth/wesnoth/commit/314425ab0e57b32909d324f7d4bf213d62cbd3b5
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-05-16 (Fri, 16 May 2014)

  Changed paths:
    M changelog
    M src/filesystem.cpp

  Log Message:
  -----------
  fs: Use game data path to resolve ./ in the absence of a current_dir

Fixes a file content disclosure bug (#22042) affecting functionality
relying on the get_wml_location() function and not passing a non-empty
value for the current_dir parameter.

See <https://gna.org/bugs/?22042> for details.

This is a candidate for the 1.10 and 1.12 branches.


  Commit: 9f458d1bb29cef4318c8511965083edd1128c62e
      https://github.com/wesnoth/wesnoth/commit/9f458d1bb29cef4318c8511965083edd1128c62e
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2014-05-16 (Fri, 16 May 2014)

  Changed paths:
    M src/filesystem.cpp

  Log Message:
  -----------
  fs: Assert that game_config::path is not empty in get_wml_location()

Let's see if this breaks some absurd border case I couldn't think of.
Quick testing revealed that early initialization, campaignd, and
wesnothd at least did not fail the assertion check.


Compare: https://github.com/wesnoth/wesnoth/compare/93353ee0a67b...9f458d1bb29c