[Commits] [wesnoth/wesnoth] 77993f: fixup [command] [move] implementation

GitHub noreply at github.com
Sat May 17 01:26:18 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 77993f9d988c9baf112a12db5e3d3047506f640f
      https://github.com/wesnoth/wesnoth/commit/77993f9d988c9baf112a12db5e3d3047506f640f
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-16 (Fri, 16 May 2014)

  Changed paths:
    M src/synced_commands.cpp

  Log Message:
  -----------
  fixup [command] [move] implementation

The move implementation used a function from map_location.cpp,
parse_location_range. This has the consequence that if the move tag
has mismatched numbers of entries for x and y, it is not reported
as an error and instead some truly bizarre, although not "undefined"
behavior ensues. Since this has obvious potential to conceal bugs
and no obvious benefit, I have changed this to a more sane
implementation. See chat log today with gfgtdf for full details.


  Commit: d7374f4080c2072fce1955b60da03e8489455784
      https://github.com/wesnoth/wesnoth/commit/d7374f4080c2072fce1955b60da03e8489455784
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-16 (Fri, 16 May 2014)

  Changed paths:
    A data/test/scenarios/test_move.cfg
    M wml_test_schedule

  Log Message:
  -----------
  add test_move unit tests


Compare: https://github.com/wesnoth/wesnoth/compare/9964be28499d...d7374f4080c2


More information about the Commits mailing list