[Commits] [wesnoth/wesnoth] 43166e: small refactor of strict mode logging

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 43166e03c56f74e61f25e7e3cbac4ca23d395497
      https://github.com/wesnoth/wesnoth/commit/43166e03c56f74e61f25e7e3cbac4ca23d395497
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-17 (Sat, 17 May 2014)

  Changed paths:
    M src/log.cpp

  Log Message:
  -----------
  small refactor of strict mode logging

Move a bool flag that remembers if we threw an exception, to be a
local static variable in that function, rather than at file scope.
This ensures that no other functions will mess with it.


  Commit: 8fafdbecd42db07f23a2bea4c3a1ea08b6128d22
      https://github.com/wesnoth/wesnoth/commit/8fafdbecd42db07f23a2bea4c3a1ea08b6128d22
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-17 (Sat, 17 May 2014)

  Changed paths:
    M src/CMakeLists.txt
    M src/SConscript
    R src/builder.cpp
    R src/builder.hpp
    M src/display.cpp
    M src/editor/editor_display.cpp
    M src/game_config_manager.cpp
    M src/menu_events.cpp
    A src/terrain_builder.cpp
    A src/terrain_builder.hpp

  Log Message:
  -----------
  rename builder.cpp -> terrain_builder.cpp

Since that's the class that it defines.


  Commit: 49dc82b5d8f2e3f07258247d700458baa7c73902
      https://github.com/wesnoth/wesnoth/commit/49dc82b5d8f2e3f07258247d700458baa7c73902
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-17 (Sat, 17 May 2014)

  Changed paths:
    M src/lexical_cast.hpp

  Log Message:
  -----------
  bad_lexical_cast derives from std::exception


  Commit: afb3fec155fc7c4035dcb9c9cd6e411c8e2e0410
      https://github.com/wesnoth/wesnoth/commit/afb3fec155fc7c4035dcb9c9cd6e411c8e2e0410
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-17 (Sat, 17 May 2014)

  Changed paths:
    M src/actions/undo.cpp
    M src/actions/undo.hpp
    M src/game_events/action_wml.cpp
    M src/map_location.hpp
    M src/playsingle_controller.cpp

  Log Message:
  -----------
  catch bad lexical casts (from parsing map locations from configs)


  Commit: b242735c7e191e43cbd6ae80238bad1284a74970
      https://github.com/wesnoth/wesnoth/commit/b242735c7e191e43cbd6ae80238bad1284a74970
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-17 (Sat, 17 May 2014)

  Changed paths:
    M src/CMakeLists.txt
    M src/SConscript
    A src/tests/test_map_location.cpp

  Log Message:
  -----------
  add map_location characterization tests

There is a compiler option to generate the expected output set for
the current build, see test_map_location.cpp


  Commit: 39f2b669ae990e00278b41534b3b929144bccbca
      https://github.com/wesnoth/wesnoth/commit/39f2b669ae990e00278b41534b3b929144bccbca
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-17 (Sat, 17 May 2014)

  Changed paths:
    M src/synced_commands.cpp

  Log Message:
  -----------
  refactor synced_commands [move] to use read_locations, not reimpl.


  Commit: 3e6c6d1f168ea0ae2a5e2964ce43dbb57f71b26b
      https://github.com/wesnoth/wesnoth/commit/3e6c6d1f168ea0ae2a5e2964ce43dbb57f71b26b
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-17 (Sat, 17 May 2014)

  Changed paths:
    M src/tests/test_map_location.cpp

  Log Message:
  -----------
  fixup test_map_location.cpp

Was checking vector sum commutativity twice, replaced with an
anticommutativity test for vector_difference.


  Commit: 9e600ac0f6571383a661f7eb148e8eb27042b512
      https://github.com/wesnoth/wesnoth/commit/9e600ac0f6571383a661f7eb148e8eb27042b512
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-17 (Sat, 17 May 2014)

  Changed paths:
    M src/map_location.cpp
    M src/synced_commands.cpp

  Log Message:
  -----------
  Fix map_locations.cpp read_locations function

read_locations will no longer silently process a mismatched list of
x and y integers as a valid path, instead it will throw a
bad_lexical_cast. gfgtdf and I discussed on irc, we don't believe
that this will break save or replay compatibility, and it could
potentially help to catch possible OOS bugs in the future. I am
currently passing all my C++ and WML unit tests with this commit.

This commit also changes the [command] [move] handler over to use
this function directly without checking for mismatched lists, so
if this commit is reverted that function will still work correctly.


  Commit: 96ba999d49e92a23eb70a55617d2d87056bd1f2e
      https://github.com/wesnoth/wesnoth/commit/96ba999d49e92a23eb70a55617d2d87056bd1f2e
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-17 (Sat, 17 May 2014)

  Changed paths:
    M src/map_location.cpp

  Log Message:
  -----------
  improve the performance of map_location.cpp

For two variables known to be either 0 or 1, && is faster than *.
For example && can short-circuit and * cannot in C++ afaik.


  Commit: d4df8f165ab89360b702d680fdf9b5b7923cef99
      https://github.com/wesnoth/wesnoth/commit/d4df8f165ab89360b702d680fdf9b5b7923cef99
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-17 (Sat, 17 May 2014)

  Changed paths:
    M src/CMakeLists.txt
    M src/SConscript
    M src/actions/undo.cpp
    M src/actions/undo.hpp
    R src/builder.cpp
    R src/builder.hpp
    M src/display.cpp
    M src/editor/editor_display.cpp
    M src/game_config_manager.cpp
    M src/game_events/action_wml.cpp
    M src/lexical_cast.hpp
    M src/log.cpp
    M src/map_location.cpp
    M src/map_location.hpp
    M src/menu_events.cpp
    M src/playsingle_controller.cpp
    M src/synced_commands.cpp
    A src/terrain_builder.cpp
    A src/terrain_builder.hpp
    A src/tests/test_map_location.cpp

  Log Message:
  -----------
  Merge branch 'map_location'


Compare: https://github.com/wesnoth/wesnoth/compare/6475cd1ad2d7...d4df8f165ab8