[Commits] [wesnoth/wesnoth] c73b59: add static const members ZERO, default_dirs, of ma...

GitHub noreply at github.com
Tue May 20 15:26:12 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c73b5945d9946553386bc66b92c7021e6df3dc83
      https://github.com/wesnoth/wesnoth/commit/c73b5945d9946553386bc66b92c7021e6df3dc83
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M src/ai/default/contexts.cpp
    M src/editor/action/action.hpp
    M src/editor/map/map_fragment.cpp
    M src/halo.cpp
    M src/map.cpp
    M src/map_location.cpp
    M src/map_location.hpp
    M src/terrain_filter.cpp
    M src/tests/test_map_location.cpp
    M src/unit.cpp

  Log Message:
  -----------
  add static const members ZERO, default_dirs, of map_location

Replace local constants appearing elsewhere with these.
The definitions are inlined.


  Commit: c5838b9513a6d9680697252045cf7869bf71374b
      https://github.com/wesnoth/wesnoth/commit/c5838b9513a6d9680697252045cf7869bf71374b
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M src/actions/attack.cpp
    M src/actions/attack.hpp
    M src/actions/create.cpp
    M src/actions/create.hpp
    M src/actions/move.cpp
    M src/actions/vision.cpp
    M src/ai/actions.cpp
    M src/ai/contexts.cpp
    M src/ai/contexts.hpp
    M src/ai/formula/function_table.cpp
    M src/ai/lua/core.cpp
    M src/ai/recruitment/recruitment.cpp
    M src/ai/testing/ca.cpp
    M src/callable_objects.cpp
    M src/controller_base.cpp
    M src/display.hpp
    M src/editor/editor_controller.hpp
    M src/game_display.cpp
    M src/game_events/action_wml.cpp
    M src/game_events/entity_location.cpp
    M src/gamestatus.cpp
    M src/joystick.cpp
    M src/map.cpp
    M src/map_location.cpp
    M src/map_location.hpp
    M src/menu_events.cpp
    M src/mouse_events.cpp
    M src/mouse_events.hpp
    M src/mouse_handler_base.hpp
    M src/pathfind/astarsearch.cpp
    M src/pathfind/pathfind.cpp
    M src/pathutils.cpp
    M src/play_controller.cpp
    M src/tod_manager.cpp
    M src/tod_manager.hpp
    M src/unit.hpp
    M src/unit_abilities.cpp
    M src/unit_abilities.hpp
    M src/unit_animation.hpp
    M src/unit_display.cpp
    M src/unit_display.hpp
    M src/unit_types.cpp
    M src/whiteboard/recall.cpp

  Log Message:
  -----------
  inline the definition map_location::null_location

If we decided it was worth it to inline map_location ==, then
surely this is also worth it to inline null_location, as the
compiler may be able to reduce tests for == null location to
"x == ... && y == ...", without having to move to a different
compilation unit.


  Commit: 302b0a831bfdd2685c233f6305e4eac9fbb99e38
      https://github.com/wesnoth/wesnoth/commit/302b0a831bfdd2685c233f6305e4eac9fbb99e38
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M src/filesystem.cpp
    M src/filesystem.hpp
    M src/preferences.cpp

  Log Message:
  -----------
  fixup travis (failure to find preferences is not reported as error)


Compare: https://github.com/wesnoth/wesnoth/compare/4b64eea0a6c7...302b0a831bfd


More information about the Commits mailing list