[Commits] [wesnoth/wesnoth] c55f3c: Move animationless moving unit hiding to a more ap...

[GitHub]

  Branch: refs/heads/1.12
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c55f3cd4c74be21da1ae4dc0f06754b3d4ea42c2
      https://github.com/wesnoth/wesnoth/commit/c55f3cd4c74be21da1ae4dc0f06754b3d4ea42c2
  Author: Alexander van Gessel <ai0867 at gmail.com>
  Date:   2014-05-27 (Tue, 27 May 2014)

  Changed paths:
    M src/unit_display.cpp

  Log Message:
  -----------
  Move animationless moving unit hiding to a more appropriate place

Unit hiding is usually done in replace_temporary, which is called by
proceed_to. As proceed_to exits at the beginning if animate is false, this
would seem like a good place to hide the unit, but it is also unhidden during
this function. This means that was_hidden_ is set multiple times, with the
second time overwriting it with the temporary state of being hidden.
As animate remains false for the entire lifetime of the unit mover, we hide it
at the start and let finish unhide it again.

Reported at http://r.wesnoth.org/p570866