[Commits] [wesnoth/wesnoth] bf0fca: assert that do_init_side functions are never calle...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: bf0fca4d83deafffb2eb2e6cdc576a8815222e5f
      https://github.com/wesnoth/wesnoth/commit/bf0fca4d83deafffb2eb2e6cdc576a8815222e5f
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-29 (Thu, 29 May 2014)

  Changed paths:
    M src/play_controller.cpp

  Log Message:
  -----------
  assert that do_init_side functions are never called with bad arg


  Commit: 1e4858fa4ace62e0df8fd8b35ced4e3fb7e38573
      https://github.com/wesnoth/wesnoth/commit/1e4858fa4ace62e0df8fd8b35ced4e3fb7e38573
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-29 (Thu, 29 May 2014)

  Changed paths:
    M src/play_controller.cpp
    M src/play_controller.hpp
    M src/playsingle_controller.cpp
    M src/playturn.cpp
    M src/replay.cpp
    M src/replay_controller.cpp

  Log Message:
  -----------
  remove unnecessary arguments

maybe_do_init_side and do_init_side both required a team_index
argument, which was always player_number_ - 1, (checked this with
assertions and playtesting), and which was available in the class
which defined them


Compare: https://github.com/wesnoth/wesnoth/compare/0af672c5b7a5...1e4858fa4ace