[Commits] [wesnoth/wesnoth] 15e811: remove unnecessary arguments

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 15e81134fb2b0cc282d01f2ea8ec422fb74d484e
      https://github.com/wesnoth/wesnoth/commit/15e81134fb2b0cc282d01f2ea8ec422fb74d484e
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-30 (Fri, 30 May 2014)

  Changed paths:
    M src/play_controller.hpp
    M src/playmp_controller.cpp
    M src/playmp_controller.hpp
    M src/playsingle_controller.cpp
    M src/playsingle_controller.hpp
    M src/replay_controller.cpp
    M src/replay_controller.hpp

  Log Message:
  -----------
  remove unnecessary arguments

All of before_human_turn, play_side, play_turn had an argument
"bool save". The only use of this was by the playsingle controller
to determine whether or not to save an autosave -- it was controlled
in a single place by a single for loop in play_scenario.

Instead of polluting all of these functions, including play_controller,
and replay_controller, with arguments that they ignore, save was
replaced with a member variable of playsingle_controller. This is a
strict refactor in terms of behavior.