[Commits] [wesnoth/wesnoth] ef5417: remove unnecessary variable "turn_over_" from play...

GitHub noreply at github.com
Sat May 31 01:22:19 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: ef5417f60fa20927ed763b45630c6b4bc7897545
      https://github.com/wesnoth/wesnoth/commit/ef5417f60fa20927ed763b45630c6b4bc7897545
  Author: Chris Beck <render787 at gmail.com>
  Date:   2014-05-30 (Fri, 30 May 2014)

  Changed paths:
    M src/playmp_controller.cpp
    M src/playsingle_controller.cpp
    M src/playsingle_controller.hpp

  Log Message:
  -----------
  remove unnecessary variable "turn_over_" from play_controllers.

After other refactors, this variable is basically useless -- it
is only used in one function, and indicates to that function if
we called it from the normal sp path, or the mp linger code path.
We choose to replace it with the linger_ variable -- the sp code
path will never follow to this function if linger_ is true, and
if it did it would cause a serious error anyways and corrupt
replays, so we would know if this was happening. So this is a
strict refactor.





More information about the Commits mailing list