[Commits] [wesnoth/wesnoth] 7a2ac9: set "init_side_done_ = false; " sooner

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 7a2ac99098231aaaf0a4ac2e01336ed8b0f32ce4
      https://github.com/wesnoth/wesnoth/commit/7a2ac99098231aaaf0a4ac2e01336ed8b0f32ce4
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-02-25 (Wed, 25 Feb 2015)

  Changed paths:
    M src/play_controller.cpp
    M src/play_controller.hpp
    M src/playmp_controller.cpp
    M src/playsingle_controller.cpp
    M src/replay_controller.cpp

  Log Message:
  -----------
  set "init_side_done_ = false;" sooner

instead of setting init_side_done_ to false in init_side() we now do so in finish_side_turn() this makes sure that init_side has also the correct value if saved before init_side.
This could fix  https://gna.org/bugs/?23310 and also allows some refactoring/simplifications related to init_side().


  Commit: 1a008e4de7e7d6db57eb01ca9cb5e70120863555
      https://github.com/wesnoth/wesnoth/commit/1a008e4de7e7d6db57eb01ca9cb5e70120863555
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-02-25 (Wed, 25 Feb 2015)

  Changed paths:
    M src/playsingle_controller.cpp

  Log Message:
  -----------
  remove unneeded check for loading_game_

init_side_done_ implied loading_game_ there so we can simplyfy.


  Commit: 3b16f13a1849e6afd67afe56bf22cd9798eea79f
      https://github.com/wesnoth/wesnoth/commit/3b16f13a1849e6afd67afe56bf22cd9798eea79f
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-02-25 (Wed, 25 Feb 2015)

  Changed paths:
    M src/controller_base.cpp
    M src/controller_base.hpp
    M src/play_controller.cpp
    M src/play_controller.hpp
    M src/playmp_controller.cpp
    M src/playsingle_controller.cpp

  Log Message:
  -----------
  remove browse_ member from controller_base.


Compare: https://github.com/wesnoth/wesnoth/compare/b5cec4db818b...3b16f13a1849