[Commits] [wesnoth/wesnoth] d12c59: fix crash when failing to save file.

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: d12c594d90c5d683bd80fd3e05b3ee0d623a06e2
      https://github.com/wesnoth/wesnoth/commit/d12c594d90c5d683bd80fd3e05b3ee0d623a06e2
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-02-25 (Wed, 25 Feb 2015)

  Changed paths:
    M src/filesystem_boost.cpp

  Log Message:
  -----------
  fix crash when failing to save file.

https://gna.org/bugs/index.php?23301


  Commit: ec4c3d0e2639a5a20353771ee055029c7ef6b886
      https://github.com/wesnoth/wesnoth/commit/ec4c3d0e2639a5a20353771ee055029c7ef6b886
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-02-25 (Wed, 25 Feb 2015)

  Changed paths:
    M src/play_controller.cpp

  Log Message:
  -----------
  fixup 'refactor do_init_side'


  Commit: b5cec4db818b596102e5fe952ca2827bb8c0ea08
      https://github.com/wesnoth/wesnoth/commit/b5cec4db818b596102e5fe952ca2827bb8c0ea08
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-02-25 (Wed, 25 Feb 2015)

  Changed paths:
    M src/play_controller.cpp
    M src/play_controller.hpp

  Log Message:
  -----------
  fix side initialized twice when reloading multiple times in mp.

previously it was possible to get a side initilized twice in the
following case:
Steps to reproduce:
1) Start a 1vs1 Mp game with 2 clients
2) both sides end their turns so it is turn 2 now (since unita are not
healed in the first turn you wouldn not notice the bug in the first
turn)
3) Recruit a unit on side 1(with tratis, to prevent another bug
https://gna.org/bugs/?23316)
4) Save the game (with any client)
5) Reload the game in networked mp
6) Save the game with side 2
7) Reload the game
-> new newly recruited mage has full movements.
The reason is that during the first reload the value of init_side_done_
was uncorrectly set to true on client 2, so when the save was reloaded a
second time do_init_side was called again.


Compare: https://github.com/wesnoth/wesnoth/compare/f2e4d3c87531...b5cec4db818b