[Commits] [wesnoth/wesnoth] 132584: fix bug #22984: sliders not adjustable with arrow ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 132584873860c21c25a90215ce1de93faa2390ed
      https://github.com/wesnoth/wesnoth/commit/132584873860c21c25a90215ce1de93faa2390ed
  Author: Chris Beck <render787 at gmail.com>
  Date:   2015-03-05 (Thu, 05 Mar 2015)

  Changed paths:
    M src/widgets/slider.cpp

  Log Message:
  -----------
  fix bug #22984: sliders not adjustable with arrow keys

This commit causes sliders to attract focus properly when their
grips are clicked on, and to respond to left and right arrow
presses again. It partly reverts two earlier commits that
affected this functionality.

cf84e1d8aae84b76e7e9adc15847089bdc940632
49614599fa5211e0bc3fdba43c6255509da66022

It causes the zoom slider to behave slightly badly, because it
does not lose focus when the user clicks elsewhere on the map.
But this bug should be fixed at the source and not by disabling
wanted functionality for all sliders.


  Commit: 2d0a543922046c6a91ec7062a8e74b7046a1d0f9
      https://github.com/wesnoth/wesnoth/commit/2d0a543922046c6a91ec7062a8e74b7046a1d0f9
  Author: Chris Beck <render787 at gmail.com>
  Date:   2015-03-05 (Thu, 05 Mar 2015)

  Changed paths:
    M src/display.cpp
    M src/display.hpp
    M src/widgets/slider.cpp
    M src/widgets/slider.hpp

  Log Message:
  -----------
  fix zoom slider focus issue (add a separate class for zoom_slider)

When the slider widget was added to ThemeWML, some work was not
done apparently to make it play nicely with regards to focus and
key events with the other theme wml widgets, causing it to retain
focus for keyboard events indefinitely. At the time this was
resolved by disabling these events, but this cripples the many
other sliders in the game. In this commit we introduce a subclass
zoom_slider which has this functionality disabled, and use that
for zoom sliders, so that we can get the desired functionality
back for the other sliders. See parent of this commit for more
info.


  Commit: 263f51bb154812b66100a6f6428a6f48b7900418
      https://github.com/wesnoth/wesnoth/commit/263f51bb154812b66100a6f6428a6f48b7900418
  Author: Chris Beck <beck.ct at gmail.com>
  Date:   2015-03-05 (Thu, 05 Mar 2015)

  Changed paths:
    M src/display.cpp
    M src/display.hpp
    M src/widgets/slider.cpp
    M src/widgets/slider.hpp

  Log Message:
  -----------
  Merge pull request #376 from cbeck88/fixup_sliders

fix bug #22984: sliders not adjustable with arrow keys


Compare: https://github.com/wesnoth/wesnoth/compare/9b78a41d25d2...263f51bb1548