[Commits] [wesnoth/wesnoth] bb0ecd: recorder writes directly into saved_game object

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: bb0ecd14c0759006efcc792fea27127cd1a0122a
      https://github.com/wesnoth/wesnoth/commit/bb0ecd14c0759006efcc792fea27127cd1a0122a
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-03-06 (Fri, 06 Mar 2015)

  Changed paths:
    M src/CMakeLists.txt
    M src/SConscript
    M src/actions/move.cpp
    M src/actions/undo.cpp
    M src/ai/actions.cpp
    M src/ai/formula/function_table.cpp
    M src/ai/testing.cpp
    M src/ai/testing/ca_global_fallback.cpp
    M src/dialogs.cpp
    M src/game_events/action_wml.cpp
    M src/game_initialization/multiplayer.cpp
    M src/game_initialization/playcampaign.cpp
    M src/menu_events.cpp
    M src/play_controller.cpp
    M src/play_controller.hpp
    M src/playmp_controller.cpp
    M src/playsingle_controller.cpp
    M src/playturn.cpp
    M src/replay.cpp
    M src/replay.hpp
    M src/replay_controller.cpp
    A src/replay_recorder_base.cpp
    A src/replay_recorder_base.hpp
    M src/resources.cpp
    M src/resources.hpp
    M src/saved_game.cpp
    M src/saved_game.hpp
    M src/savegame.cpp
    M src/synced_context.cpp
    M src/wesnoth.cpp

  Log Message:
  -----------
  recorder writes directly into saved_game object

Previously recorder had config memaber and saved_game had a config
memeber.
And when saving a game the config was copied from recorder to saved_game
and the other way when loading a game.

Now the recorder object directly writes into the saved_game object. This
saves some copying when saving and loading data.

I also moved the pos_ variable from the recorder object to the
saved_game replay_recorder_base object, This fixes a bug where saving a
game during a replay also caused to not yet played turns to be written
into the savefile.


  Commit: b9904f6557646cc4dccc68cbb829068da18125fc
      https://github.com/wesnoth/wesnoth/commit/b9904f6557646cc4dccc68cbb829068da18125fc
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2015-03-06 (Fri, 06 Mar 2015)

  Changed paths:
    M src/synced_context.cpp

  Log Message:
  -----------
  dont do replay checkup in set_sconext_synced destructor

Previously it was dont this way because we also wanted a replay chack in
case of an end_level_exception which was thrown by check_victory. Since
check_victory doesnt throw anymore this is not needed anymore.


Compare: https://github.com/wesnoth/wesnoth/compare/9aa6bb37fd34...b9904f655764