[Commits] [wesnoth/wesnoth] c05b8e: MP Staging: fixed bug where type id was displayed ...

GitHub noreply at github.com
Sat Oct 1 00:23:29 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c05b8efc3fb52103209ca1442cbb0f4e4161bdb8
      https://github.com/wesnoth/wesnoth/commit/c05b8efc3fb52103209ca1442cbb0f4e4161bdb8
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-10-01 (Sat, 01 Oct 2016)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_staging.cpp

  Log Message:
  -----------
  MP Staging: fixed bug where type id was displayed instead of name


  Commit: b4d460cd164c50fcf915ee6f2aa89d36bf3f32fa
      https://github.com/wesnoth/wesnoth/commit/b4d460cd164c50fcf915ee6f2aa89d36bf3f32fa
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-10-01 (Sat, 01 Oct 2016)

  Changed paths:
    M data/gui/window/mp_join_game.cfg
    M src/gui/dialogs/multiplayer/mp_join_game.cpp

  Log Message:
  -----------
  MP Join Game: layout improvements


  Commit: 722600a313dc91ace419e36f02aee1169d483f8d
      https://github.com/wesnoth/wesnoth/commit/722600a313dc91ace419e36f02aee1169d483f8d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-10-01 (Sat, 01 Oct 2016)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_staging.cpp
    M src/gui/dialogs/multiplayer/mp_staging.hpp

  Log Message:
  -----------
  MP Staging: refactored handling of settings changes

Instead of immediately regenerating the side configs and pushing them to server in every widget callback (which
is especially expensive in the case of the gold and income sliders), we push updates to the server when the
network callback is called if the state_changed_ flag has been set.

This also cleans up some code from the previous attempt to make both the host and clients utilize this dialog.

Additionally, this fixes gold/income changes not being sent to the server.


Compare: https://github.com/wesnoth/wesnoth/compare/8b5791c657cf...722600a313dc


More information about the Commits mailing list