[Commits] [wesnoth/wesnoth] 9b6fc7: Revert "MP Create: basic implementation of saved g...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 9b6fc78690cceb292bf3fe8b5fbd0a3c39f25167
      https://github.com/wesnoth/wesnoth/commit/9b6fc78690cceb292bf3fe8b5fbd0a3c39f25167
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-10-05 (Wed, 05 Oct 2016)

  Changed paths:
    M src/game_initialization/create_engine.cpp
    M src/game_initialization/create_engine.hpp
    M src/game_initialization/multiplayer_create.cpp
    M src/gui/dialogs/multiplayer/mp_create_game.cpp

  Log Message:
  -----------
  Revert "MP Create: basic implementation of saved games as their own category (debug only)"

This reverts commit 9a569df848f3b7d774ac29c100a4f36c4923b7bd.

This commit somehow causes massive lag when opening the Campaign dialog with a large (several hundred) saves.
Somehow, the save_index was being regenerated every single time a new save was processed, likely due to
the calling of save.summary() in the create_engine initialization loop. It remains to be seen if this is a bug
in the save_index code, which seems possible.

This commit was also likely the cause of bug #25146. While the fix for that might have been simpler (short-circuiting
the campaign type conditional with a savefile corruption check), since this commit has already caused issues, it's
best to revert it and revisit this idea at another time.