[Commits] [wesnoth/wesnoth] 1528a8: Refactor luaL_typerror

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 1528a8bb5a35c805fa9508a6f1690648f6f4a097
      https://github.com/wesnoth/wesnoth/commit/1528a8bb5a35c805fa9508a6f1690648f6f4a097
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2016-10-10 (Mon, 10 Oct 2016)

  Changed paths:
    M src/ai/lua/core.cpp
    M src/lua/lauxlib.cpp
    M src/lua/lauxlib.h
    M src/scripting/lua_common.cpp
    M src/scripting/lua_common.hpp
    M src/scripting/lua_formula_bridge.cpp
    M src/scripting/lua_gui2.cpp
    M src/scripting/lua_unit.cpp
    M src/scripting/lua_unit_attacks.cpp

  Log Message:
  -----------
  Refactor luaL_typerror

Lua deprecated luaL_typerror. Wesnoth needs it. Traditionally this was handled as a by-hand edit to the Lua source kit. Refactored into Wesnoth as luaW_type_error.


  Commit: 196a044dd6cf0b7c56448eaeae0491cfb6a3493e
      https://github.com/wesnoth/wesnoth/commit/196a044dd6cf0b7c56448eaeae0491cfb6a3493e
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2016-10-10 (Mon, 10 Oct 2016)

  Changed paths:
    M src/lua/lgc.cpp

  Log Message:
  -----------
  Revert spurious change to whitespace


  Commit: be43e6c730916e79e6861531ad38f61ef55ad59f
      https://github.com/wesnoth/wesnoth/commit/be43e6c730916e79e6861531ad38f61ef55ad59f
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2016-10-10 (Mon, 10 Oct 2016)

  Changed paths:
    M src/lua/llex.cpp

  Log Message:
  -----------
  Fix bug: Index out of bounds

Revert this commit. There was no off-by-one but this commit created one.

Commit commit 299a29f99a84767731dbadd540712d1a37e5e10d
Author: Alexander van Gessel <ai0867 at gmail.com>
Date:   Mon Dec 2 17:55:02 2013 +0100

    Fix an off-by-one past-the-end buffer read in lua

    Found by coverity


  Commit: 299b0cc55c70a8e32f3a7f0ef16d4323f063d7a4
      https://github.com/wesnoth/wesnoth/commit/299b0cc55c70a8e32f3a7f0ef16d4323f063d7a4
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2016-10-10 (Mon, 10 Oct 2016)

  Changed paths:
    M src/lua/lmathlib.cpp

  Log Message:
  -----------
  No need to redefine PI

Lua, as released, has the correct definition of PI for 'double' (64-bit) floats. It is as precise as possible. If the Boost 128- or 256-bit definitions produce a different value than what Lua provides either (1) we're no longer on 64-bit double floats, (2) there is a typo in Boost, or (3) there is a bug in your compiler.

This reverts the Lua portion of the following commit:

commit f5e673e6443220c57e40cea31d430870b4f73925
Author: fendrin <fabianmueller5 at gmx.de>
Date:   Thu Sep 19 01:06:23 2013 +0200

    Replace all kinds of the constant pi representations.

    Replaces every appearance of the circle constant pi I could find with
    the representation from boost/math/constants/constants.hpp.


  Commit: 426d57b4b74f909895ff2ce316e9bc2be9f6ebf5
      https://github.com/wesnoth/wesnoth/commit/426d57b4b74f909895ff2ce316e9bc2be9f6ebf5
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2016-10-10 (Mon, 10 Oct 2016)

  Changed paths:
    M src/ai/lua/core.cpp
    M src/lua/lauxlib.cpp
    M src/lua/lauxlib.h
    M src/lua/lgc.cpp
    M src/lua/llex.cpp
    M src/lua/lmathlib.cpp
    M src/scripting/lua_common.cpp
    M src/scripting/lua_common.hpp
    M src/scripting/lua_formula_bridge.cpp
    M src/scripting/lua_gui2.cpp
    M src/scripting/lua_unit.cpp
    M src/scripting/lua_unit_attacks.cpp

  Log Message:
  -----------
  Merge pull request #815 from GregoryLundberg/GL_Lua

Lua integration cleanup


Compare: https://github.com/wesnoth/wesnoth/compare/c91a65dde4c2...426d57b4b74f