[Commits] [wesnoth/wesnoth] 5aaa9b: Game Config Manager: [side] no_leader should not d...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5aaa9bae4e549d6161b72b8000dc7b6c5d003f4f
      https://github.com/wesnoth/wesnoth/commit/5aaa9bae4e549d6161b72b8000dc7b6c5d003f4f
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-10-11 (Tue, 11 Oct 2016)

  Changed paths:
    M src/game_config_manager.cpp

  Log Message:
  -----------
  Game Config Manager: [side] no_leader should not default to true if absent

I'm not sure if this was a mistake or deliberate, but either way, it results in the no_leader key
on every side in MP always being true.


  Commit: ecaec3bf07b5bf7c7f2107b803ea79270c2f32a8
      https://github.com/wesnoth/wesnoth/commit/ecaec3bf07b5bf7c7f2107b803ea79270c2f32a8
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-10-11 (Tue, 11 Oct 2016)

  Changed paths:
    M src/game_initialization/connect_engine.cpp
    M src/game_initialization/connect_engine.hpp

  Log Message:
  -----------
  Connect Engine: include no_leader key in player allowed check

The game already hides sides with allow_player = false in MP game creation, except in debug mode. However,
if one loads an SP campaign (granted, the functionality to do so is hidden behind debug mode), leaderless
sides display anyway. This hides them as well.


  Commit: 3576f2ae43cb51fc2e8a6c20ecafd0fe55cbe2d4
      https://github.com/wesnoth/wesnoth/commit/3576f2ae43cb51fc2e8a6c20ecafd0fe55cbe2d4
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-10-11 (Tue, 11 Oct 2016)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_staging.cpp

  Log Message:
  -----------
  MP Staging: fixed display of sides with no or invalid leaders

This fixes a crash that happened if a side had no leader specified, and stops displaying the Random
image in the same case.


  Commit: 3197db5bf6981a52658734362d8c6a3f5f1e713e
      https://github.com/wesnoth/wesnoth/commit/3197db5bf6981a52658734362d8c6a3f5f1e713e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-10-11 (Tue, 11 Oct 2016)

  Changed paths:
    M data/gui/window/mp_staging.cfg

  Log Message:
  -----------
  MP Staging: small UI tweaks


Compare: https://github.com/wesnoth/wesnoth/compare/abc9a599b6f8...3197db5bf698