[Commits] [wesnoth/wesnoth] 6513d6: fixup! Fix Lua-invoked dialogs not showing before ...

GitHub noreply at github.com
Thu Oct 20 07:22:09 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 6513d6ac018cc8a6f346abb3f007de993401694f
      https://github.com/wesnoth/wesnoth/commit/6513d6ac018cc8a6f346abb3f007de993401694f
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2016-10-20 (Thu, 20 Oct 2016)

  Changed paths:
    M src/game_initialization/create_engine.cpp
    M src/game_initialization/create_engine.hpp
    M src/game_initialization/multiplayer_create.cpp
    M src/generators/default_map_generator.cpp
    M src/generators/default_map_generator.hpp
    M src/generators/lua_map_generator.hpp
    M src/generators/map_generator.cpp
    M src/generators/map_generator.hpp
    M src/gui/dialogs/editor/generate_map.cpp
    M src/gui/dialogs/editor/generate_map.hpp
    M src/gui/dialogs/multiplayer/mp_create_game.cpp

  Log Message:
  -----------
  fixup! Fix Lua-invoked dialogs not showing before prestart
09d35947f4a05082ec34be292b73a4efc631e1d8

The mentioned commit broke the Lua map generator by removing a parameter from an
overridden method. This commit fixes that by removing it from the superclass as well
and cascading that through.

In addition, override annotations have been added to the generators to guard against
similar mistakes in the future.





More information about the Commits mailing list