[Commits] [wesnoth/wesnoth] c2e6fd: MP Create Game: don't update tab contents when reg...

GitHub noreply at github.com
Sat Oct 22 10:39:40 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c2e6fda94c01357cc9605f720e1443c57942498a
      https://github.com/wesnoth/wesnoth/commit/c2e6fda94c01357cc9605f720e1443c57942498a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-10-22 (Sat, 22 Oct 2016)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_create_game.cpp

  Log Message:
  -----------
  MP Create Game: don't update tab contents when regenerating random maps

This moves the tab update code to on_game_select from update_details, since the latter is called when
regenerating random maps and doing so has no possibility of changing tab contents. The only thing that
can do that is selecting a new game. If this ceases to be true in the future, this can be reverted.

This probably should have been done in 80115b11faa3 - in fact, the commit message makes it sound like
it was, but it was not due to an oversight on my part.





More information about the Commits mailing list