[Commits] [wesnoth/wesnoth] e42f07: Use an existing typedef to simplify two declaratio...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: e42f079d78184389d7cd031786b8eff7a59bfc4d
      https://github.com/wesnoth/wesnoth/commit/e42f079d78184389d7cd031786b8eff7a59bfc4d
  Author: JaMiT <jt_coding at zoho.com>
  Date:   2016-09-05 (Mon, 05 Sep 2016)

  Changed paths:
    M src/editor/toolkit/editor_toolkit.cpp

  Log Message:
  -----------
  Use an existing typedef to simplify two declarations


  Commit: ee03df92ab390f713cd72b9998cf50b3b85df417
      https://github.com/wesnoth/wesnoth/commit/ee03df92ab390f713cd72b9998cf50b3b85df417
  Author: JaMiT <jt_coding at zoho.com>
  Date:   2016-09-05 (Mon, 05 Sep 2016)

  Changed paths:
    M src/editor/toolkit/editor_toolkit.cpp
    M src/editor/toolkit/editor_toolkit.hpp

  Log Message:
  -----------
  Change a raw pointer to a shared pointer

This makes sure the memory is freed, addressing bug #24499, or at
least most of it.


  Commit: a422e657a4a62df0ff077e4cfc470bddf4df8621
      https://github.com/wesnoth/wesnoth/commit/a422e657a4a62df0ff077e4cfc470bddf4df8621
  Author: JaMiT <jt_coding at zoho.com>
  Date:   2016-09-05 (Mon, 05 Sep 2016)

  Changed paths:
    M src/editor/palette/editor_palettes.cpp
    M src/editor/palette/editor_palettes.hpp
    M src/editor/palette/item_palette.cpp
    M src/editor/palette/item_palette.hpp
    M src/editor/palette/location_palette.cpp
    M src/editor/palette/location_palette.hpp
    M src/editor/palette/palette_manager.cpp
    M src/editor/palette/palette_manager.hpp
    M src/editor/palette/terrain_palettes.cpp
    M src/editor/palette/terrain_palettes.hpp
    M src/editor/palette/unit_palette.cpp
    M src/editor/palette/unit_palette.hpp
    M src/editor/toolkit/editor_toolkit.cpp
    M src/editor/toolkit/editor_toolkit.hpp

  Log Message:
  -----------
  Use editor_toolkit& instead of mouse_action** in palettes

This goes along with the principle of using references when a pointer
cannot be null. It's also better for data encapsulation to not give
someone the address of one of your private data members.


  Commit: a6d23581e1210fc6b89bec360ecaa57e1da43357
      https://github.com/wesnoth/wesnoth/commit/a6d23581e1210fc6b89bec360ecaa57e1da43357
  Author: JaMiT <jt_coding at zoho.com>
  Date:   2016-09-05 (Mon, 05 Sep 2016)

  Changed paths:
    M src/editor/controller/editor_controller.cpp
    M src/editor/controller/editor_controller.hpp
    M src/editor/palette/location_palette.cpp
    M src/editor/toolkit/editor_toolkit.cpp
    M src/editor/toolkit/editor_toolkit.hpp

  Log Message:
  -----------
  Return mouse_action by reference instead of a not-null pointer

Plus the implementation of a previously-declared wrapper function
to get said mouse_action.


  Commit: 4212a3c66020f1423ad57837e584185546018d29
      https://github.com/wesnoth/wesnoth/commit/4212a3c66020f1423ad57837e584185546018d29
  Author: JaMiT <jt_coding at zoho.com>
  Date:   2016-09-05 (Mon, 05 Sep 2016)

  Changed paths:
    M src/editor/toolkit/editor_toolkit.hpp

  Log Message:
  -----------
  Doxygen for new function


  Commit: 44741dc36d86c6d6dbc4bb573d6cc3ce02e98c2b
      https://github.com/wesnoth/wesnoth/commit/44741dc36d86c6d6dbc4bb573d6cc3ce02e98c2b
  Author: JaMiT <jt_coding at zoho.com>
  Date:   2016-09-05 (Mon, 05 Sep 2016)

  Changed paths:
    M src/editor/action/mouse/mouse_action.hpp
    M src/editor/action/mouse/mouse_action_select.hpp
    M src/editor/controller/editor_controller.hpp

  Log Message:
  -----------
  Add some const, virtual, and override qualifiers

Also a new non-const version of a wrapper.


  Commit: 24a4dd8062a24ecfd5d1113197d7e950746bc884
      https://github.com/wesnoth/wesnoth/commit/24a4dd8062a24ecfd5d1113197d7e950746bc884
  Author: JaMiT <jt_coding at zoho.com>
  Date:   2016-09-05 (Mon, 05 Sep 2016)

  Changed paths:
    M src/editor/toolkit/editor_toolkit.cpp
    M src/editor/toolkit/editor_toolkit.hpp

  Log Message:
  -----------
  Replace raw pointer with shared pointer


Compare: https://github.com/wesnoth/wesnoth/compare/4d7df69428ad...24a4dd8062a2