[Commits] [wesnoth/wesnoth] 84e1f4: MSVC: Ignore truncated type name warnings

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 84e1f4ba4d5e5d4edaa154a45fc74110c2f463f3
      https://github.com/wesnoth/wesnoth/commit/84e1f4ba4d5e5d4edaa154a45fc74110c2f463f3
  Author: Celtic Minstrel <celtic.minstrel.ca at gmail.com>
  Date:   2016-09-06 (Tue, 06 Sep 2016)

  Changed paths:
    M projectfiles/VC12/schema_generator.vcxproj
    M projectfiles/VC12/wesnoth.vcxproj
    M projectfiles/VC12/wesnothd.vcxproj
    M projectfiles/VC12/wesnothlib.vcxproj

  Log Message:
  -----------
  MSVC: Ignore truncated type name warnings


  Commit: 0180a72573a482683485821c8d43a82a546a86c6
      https://github.com/wesnoth/wesnoth/commit/0180a72573a482683485821c8d43a82a546a86c6
  Author: Celtic Minstrel <celtic.minstrel.ca at gmail.com>
  Date:   2016-09-06 (Tue, 06 Sep 2016)

  Changed paths:
    M projectfiles/VC12/wesnoth.vcxproj
    M projectfiles/VC12/wesnoth.vcxproj.filters
    A src/SDL_SavePNG/savepng.c
    R src/SDL_SavePNG/savepng.cpp
    M src/SDL_SavePNG/savepng.h
    M src/game_initialization/multiplayer.cpp
    M src/gui/dialogs/lobby/info.cpp
    M src/gui/dialogs/multiplayer/mp_create_game.cpp
    M src/hotkey/hotkey_preferences_display.cpp
    M src/scripting/lua_gui2.cpp
    M src/scripting/lua_unit.cpp
    M src/sdl/utils.cpp
    M src/storyscreen/render.cpp
    M src/variable.hpp

  Log Message:
  -----------
  Fix lots of warnings in MSVC12

Some explanations:
- savepng uses setjmp, so I changed it to C; this guarantees that someone does not accidentally introduce a C++ object in it (unlikely though that is)
- The loop in multiplayer.cpp seemed intended to allow the command-line to request repeated plays, so the break was removed rather than refactoring it to an if statement
- Some uninitialized structs were changed to be zero-initialized
- Use luaW_toboolean instead of lua_toboolean
- Needed explicit constructor for vconfig iterators, since their only member is const


Compare: https://github.com/wesnoth/wesnoth/compare/bda24b3f938c...0180a72573a4