[Commits] [wesnoth/wesnoth] adc598: Apply recent MP test fixes to the GUI2 MP test, to...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: adc598b3889a4d6e5dc2ad4a9445ef0b81b14130
      https://github.com/wesnoth/wesnoth/commit/adc598b3889a4d6e5dc2ad4a9445ef0b81b14130
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2016-09-09 (Fri, 09 Sep 2016)

  Changed paths:
    M join-gui2.lua

  Log Message:
  -----------
  Apply recent MP test fixes to the GUI2 MP test, too


  Commit: 3366e9c683a4ff2352e118a057f391c0129df3a1
      https://github.com/wesnoth/wesnoth/commit/3366e9c683a4ff2352e118a057f391c0129df3a1
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2016-09-09 (Fri, 09 Sep 2016)

  Changed paths:
    M src/gui/dialogs/lobby/lobby.cpp
    M src/gui/dialogs/lobby/lobby.hpp

  Log Message:
  -----------
  Fix crash in GUI2 multiplayer tests


  Commit: cd779200a1bed0b6babcf7fcfb50a79814467fb0
      https://github.com/wesnoth/wesnoth/commit/cd779200a1bed0b6babcf7fcfb50a79814467fb0
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2016-09-09 (Fri, 09 Sep 2016)

  Changed paths:
    M src/gui/dialogs/lobby/lobby.cpp

  Log Message:
  -----------
  Fix crash in GUI2 multiplayer test

Because the join script attempts to join the game immediately after it has
been found, it tried to join the game before it had been added to the
games_ vector (from games_by_id_).

In addition to that, the check for if there is such a game had an
off-by-one error.

The two bugs, in combination, caused the game to index an empty vector.
Even if the STL implementation doesn't immediately crash the game, it's
going to crash later when it tries to interpret garbage data as the game
information.

Fixed by making the game update the games_ vector immediately after
fetching games from the server, and also fixing the off-by-one error.


Compare: https://github.com/wesnoth/wesnoth/compare/8a80af4c6901...cd779200a1be