[Commits] [wesnoth/wesnoth] dcc34f: Refactored twesnothd_connection member out of lobb...

GitHub noreply at github.com
Tue Sep 20 14:50:14 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: dcc34fc3286788990b1c173663482f334be28034
      https://github.com/wesnoth/wesnoth/commit/dcc34fc3286788990b1c173663482f334be28034
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-09-21 (Wed, 21 Sep 2016)

  Changed paths:
    M src/game_initialization/multiplayer.cpp
    M src/gui/dialogs/lobby/info.cpp
    M src/gui/dialogs/lobby/info.hpp
    M src/gui/dialogs/lobby/lobby.cpp
    M src/gui/widgets/chatbox.cpp
    M src/gui/widgets/chatbox.hpp

  Log Message:
  -----------
  Refactored twesnothd_connection member out of lobby_info

It's only use was to pass refresh_lobby on process_gamelist_diff fail. It makes more sense to
delegate that to the caller - in this case, the lobby. This also means the chatbox widget owns
a twesnothd_connection pointer so the chatbox can be used in situations where no server connection
is present.


  Commit: dc69c7f6c1b81b20785c13b67ab63d280213b2af
      https://github.com/wesnoth/wesnoth/commit/dc69c7f6c1b81b20785c13b67ab63d280213b2af
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-09-21 (Wed, 21 Sep 2016)

  Changed paths:
    M src/game_initialization/multiplayer.cpp

  Log Message:
  -----------
  Pass the lobby_info reference around like a hot potato


  Commit: 828d82c1ad5ddc41ef8e63d54083258b9f7e1256
      https://github.com/wesnoth/wesnoth/commit/828d82c1ad5ddc41ef8e63d54083258b9f7e1256
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-09-21 (Wed, 21 Sep 2016)

  Changed paths:
    M src/game_initialization/multiplayer.cpp
    M src/gui/dialogs/multiplayer/mp_staging.cpp
    M src/gui/dialogs/multiplayer/mp_staging.hpp

  Log Message:
  -----------
  MP Staging: enable chatbox


Compare: https://github.com/wesnoth/wesnoth/compare/c90294215a8d...828d82c1ad5d


More information about the Commits mailing list