[Commits] [wesnoth/wesnoth] fb3cae: Fix a severe performance regression on filtering a...

GitHub noreply at github.com
Sat Apr 8 15:45:49 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: fb3cae64dfed2275f18a5e19273b9ca2b1fef1f2
      https://github.com/wesnoth/wesnoth/commit/fb3cae64dfed2275f18a5e19273b9ca2b1fef1f2
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-04-08 (Sat, 08 Apr 2017)

  Changed paths:
    M src/gui/widgets/grid.cpp
    M src/gui/widgets/window.hpp

  Log Message:
  -----------
  Fix a severe performance regression on filtering add-ons

For some reason, it only occurred in debug builds when I tested.

The problem was that partial relayout didn't respect
invalidate_layout_blocker. As a result, in situations such as populating a
listbox one entry at a time, the layout system ended up performing dozens
of full relayouts that, not surprisingly, is extremely expensive.

Regression from commit 01035f0adcc40a81eddc9aab8637ee3674830735.





More information about the Commits mailing list