[Commits] [wesnoth/wesnoth] 87ea7c: Point: marked operator SDL_Point const

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 87ea7c14b0429f03bae92f18041a3702f1605cab
      https://github.com/wesnoth/wesnoth/commit/87ea7c14b0429f03bae92f18041a3702f1605cab
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/sdl/point.cpp
    M src/sdl/point.hpp

  Log Message:
  -----------
  Point: marked operator SDL_Point const


  Commit: 3b0eb6b986f722dc09b902438b22be5dbc02bda1
      https://github.com/wesnoth/wesnoth/commit/3b0eb6b986f722dc09b902438b22be5dbc02bda1
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/savegame.cpp

  Log Message:
  -----------
  Create a save_index entry when saving games

Prior to this, if you saved a game with a campaign-specific leader sprite and exited the game
or reloaded the cache *without* opening the Load Game dialog, the leader image would appear as
Unknown. This is because the save_index entry (and the accompanying path expansion) only occurred
when the save was selected in the dialog.

This change ensures all saves' leaders' images from here on out will always appear in the Load Game
dialog (unless, of course, the save_index file is deleted).


  Commit: cc62dcf9c41e2fd217545012fadfa5f59f08bd9e
      https://github.com/wesnoth/wesnoth/commit/cc62dcf9c41e2fd217545012fadfa5f59f08bd9e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/gui/dialogs/game_load.cpp

  Log Message:
  -----------
  Game Load: append leader TC if image path resolves at runtime (change by @newfrenchy83)

Closes #2257. This fixes instances where save_index entries created *before* the relevant
binary paths were loaded resulted in leader images without TC when viewed in Game Load
even once the relevant paths were loaded.

Do note as of 3b0eb6b986f722d this likely isn't a problem unless the save_index file is
deleted, since otherwise all relevant save data (including independent image paths) will
be created in-game when they're saved.

One thing to note, though, is @newfrenchy83 mentioned that the final autosaves of games
were lacking TC in the Load Game dialog. *This* change should fixe that, but I don't know
if the above change affects that too.


  Commit: bf9cac173dcdb63f58b67892a7f6eda935e252fa
      https://github.com/wesnoth/wesnoth/commit/bf9cac173dcdb63f58b67892a7f6eda935e252fa
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/save_index.cpp
    M src/save_index.hpp

  Log Message:
  -----------
  Save Index: formatting cleanup


Compare: https://github.com/wesnoth/wesnoth/compare/652270e0450c...bf9cac173dcd