[Commits] [wesnoth/wesnoth] 583670: Savegame: removed unused game_display references f...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 583670ac2b72d3535a0ae9b6a66086c7a3170b1a
      https://github.com/wesnoth/wesnoth/commit/583670ac2b72d3535a0ae9b6a66086c7a3170b1a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/play_controller.cpp
    M src/playmp_controller.cpp
    M src/playsingle_controller.cpp
    M src/savegame.cpp
    M src/savegame.hpp

  Log Message:
  -----------
  Savegame: removed unused game_display references from various classes

No idea when these became unused, though. Doesn't seem to be by CVideo argument cleanup.


  Commit: eab8380fc4ee8538ee00d78309f9702c11ddaf8c
      https://github.com/wesnoth/wesnoth/commit/eab8380fc4ee8538ee00d78309f9702c11ddaf8c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-12-03 (Sun, 03 Dec 2017)

  Changed paths:
    M src/about.cpp
    M src/addon/client.cpp
    M src/ai/configuration.cpp
    M src/ai/default/recruitment.cpp
    M src/campaign_server/campaign_server.cpp
    M src/chat_events.cpp
    M src/game_initialization/connect_engine.cpp
    M src/game_initialization/depcheck.cpp
    M src/game_initialization/multiplayer.cpp
    M src/gui/dialogs/addon/manager.cpp
    M src/gui/dialogs/campaign_difficulty.cpp
    M src/gui/dialogs/story_viewer.cpp
    M src/gui/widgets/chatbox.cpp
    M src/help/help_impl.cpp
    M src/map/label.cpp
    M src/preferences/game.cpp
    M src/replay.cpp
    M src/replay_helper.cpp
    M src/whiteboard/attack.cpp
    M src/whiteboard/move.cpp
    M src/whiteboard/recall.cpp
    M src/whiteboard/recruit.cpp
    M src/whiteboard/suppose_dead.cpp

  Log Message:
  -----------
  Avoid copying temp configs when adding config children (where possible)

A few of them are quite small, so this has no performance effect on those, but a few others
are potentially quite large, such as the one in campaign_server.cpp.


Compare: https://github.com/wesnoth/wesnoth/compare/bf9cac173dcd...eab8380fc4ee