[Commits] [wesnoth/wesnoth] cbc4af: Add blinking text cursor to focused textbox

GitHub noreply at github.com
Fri May 12 19:34:28 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: cbc4af1a201d6358519113922cd7901da893f00b
      https://github.com/wesnoth/wesnoth/commit/cbc4af1a201d6358519113922cd7901da893f00b
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-05-12 (Fri, 12 May 2017)

  Changed paths:
    M changelog
    M data/gui/widget/text_box_default.cfg
    M src/gui/widgets/text_box_base.cpp

  Log Message:
  -----------
  Add blinking text cursor to focused textbox

Unlike the previous implementation, the blinking cursor now only applies
to the focused (frontmost) window.


  Commit: a1f481f539f5a8cf38e589057db1a27732353220
      https://github.com/wesnoth/wesnoth/commit/a1f481f539f5a8cf38e589057db1a27732353220
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-05-12 (Fri, 12 May 2017)

  Changed paths:
    M src/gui/dialogs/modeless_dialog.cpp

  Log Message:
  -----------
  Fix window stack for modeless dialogs

They were not being added to the stack at all, because unlike with
modal dialogs, the window is still visible by the time the show()
function returns. They should have been removed not before reurning
from show() but instead in the hide() function.

This commit only does this for non-tooltip modeless dialogs - dialogs
that allow interaction. The reason for this is that such dialogs could
potentially contain a textbox, which uses the window stack to determine
whether to show a blinking cursor.


  Commit: 640e28f731f3606a032d9b52a42ce6caf1a9087f
      https://github.com/wesnoth/wesnoth/commit/640e28f731f3606a032d9b52a42ce6caf1a9087f
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-05-12 (Fri, 12 May 2017)

  Changed paths:
    M src/gui/widgets/text_box_base.cpp

  Log Message:
  -----------
  Don't update the textbox canvas if the cursor alpha didn't change


Compare: https://github.com/wesnoth/wesnoth/compare/0e7866db2d99...640e28f731f3


More information about the Commits mailing list