[Commits] [wesnoth/wesnoth] 936553: Don't store the user's password in plaintext in th...

[GitHub]

  Branch: refs/heads/login_save_crypt
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 9365538b3b7aa7b48ac64990f3996d60ce11297c
      https://github.com/wesnoth/wesnoth/commit/9365538b3b7aa7b48ac64990f3996d60ce11297c
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-05-12 (Fri, 12 May 2017)

  Changed paths:
    M projectfiles/VC12/wesnoth.vcxproj
    M projectfiles/VC12/wesnoth.vcxproj.filters
    M source_lists/libwesnoth
    M src/chat_events.cpp
    M src/display_chat_manager.cpp
    M src/filesystem.hpp
    M src/filesystem_common.cpp
    M src/game_initialization/configure_engine.cpp
    M src/game_initialization/connect_engine.cpp
    M src/game_initialization/create_engine.cpp
    M src/game_initialization/lobby_data.cpp
    M src/game_initialization/multiplayer.cpp
    M src/game_launcher.cpp
    M src/gui/dialogs/multiplayer/mp_change_control.cpp
    M src/gui/dialogs/multiplayer/mp_join_game.cpp
    M src/gui/dialogs/multiplayer/mp_login.cpp
    M src/gui/dialogs/multiplayer/mp_login.hpp
    M src/gui/dialogs/multiplayer/mp_method_selection.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/widgets/chatbox.cpp
    M src/menu_events.cpp
    M src/play_controller.cpp
    A src/preferences/credentials.cpp
    A src/preferences/credentials.hpp
    M src/preferences/game.cpp
    M src/preferences/game.hpp
    M src/preferences/general.cpp
    M src/server/game.cpp
    M src/tests/gui/test_gui2.cpp

  Log Message:
  -----------
  Don't store the user's password in plaintext in the prefs file

The game now supports @ or = in usernames for the purpose of saving them to a file.

Though I don't think these are allowed currently, it's probably better to
support it from the start rather than having things break if they later
become allowed.


  Commit: c9191c98122d97310eddae041a9fd3496cd5b894
      https://github.com/wesnoth/wesnoth/commit/c9191c98122d97310eddae041a9fd3496cd5b894
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-05-12 (Fri, 12 May 2017)

  Changed paths:
    M .travis.yml
    M CMakeLists.txt
    M INSTALL.md
    M SConstruct
    A cmake/FindCrypto.cmake
    M projectfiles/VC12/campaignd.vcxproj
    M projectfiles/VC12/campaignd.vcxproj.filters
    M projectfiles/VC12/wesnoth.vcxproj
    M projectfiles/VC12/wesnoth.vcxproj.filters
    M source_lists/libwesnoth_core
    M source_lists/wesnoth
    M src/CMakeLists.txt
    M src/campaign_server/campaign_server.cpp
    M src/config_cache.cpp
    M src/game_initialization/multiplayer.cpp
    M src/hash.cpp
    M src/hash.hpp
    R src/md5.cpp
    R src/md5.hpp
    R src/utils/sha1.cpp
    R src/utils/sha1.hpp
    M utils/travis/install_deps.sh

  Log Message:
  -----------
  Add OpenSSL's libcrypto as a dependency

This also removes the included SHA1 and MD5 implementations
in favour of those from OpenSSL.

Thanks to @jyrkive for helping to get the CMake build working and
ensuring the game still compiles with OpenSSL 1.1.0.
(The SHA_xxx() aliases were removed in OpenSSL 1.1.0.)


  Commit: 894ee43643976199cf410cd2970550f6edb5fa76
      https://github.com/wesnoth/wesnoth/commit/894ee43643976199cf410cd2970550f6edb5fa76
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-05-12 (Fri, 12 May 2017)

  Changed paths:
    M src/preferences/credentials.cpp

  Log Message:
  -----------
  Use RC4 cipher for encrypting the password data.

Use vectors whenever handling keys or possibly-encrypted data


  Commit: ebe360dfa5e8f51496d0dda47c5928103829f967
      https://github.com/wesnoth/wesnoth/commit/ebe360dfa5e8f51496d0dda47c5928103829f967
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-05-12 (Fri, 12 May 2017)

  Changed paths:
    M src/preferences/credentials.cpp

  Log Message:
  -----------
  Use RAII for all that zero-filling


Compare: https://github.com/wesnoth/wesnoth/compare/dce2791b3b28...ebe360dfa5e8