[Commits] [wesnoth/wesnoth] 911833: Fix halo sometimes remaining when a unit is downgr...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 9118330a308e2a6757ed9a3b388161e9e3e516c7
      https://github.com/wesnoth/wesnoth/commit/9118330a308e2a6757ed9a3b388161e9e3e516c7
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-10-04 (Wed, 04 Oct 2017)

  Changed paths:
    M src/actions/advancement.cpp
    M src/actions/attack.cpp

  Log Message:
  -----------
  Fix halo sometimes remaining when a unit is downgraded or killed

This is the rest of pull request #2028. Credit for these changes belongs to
@newfrenchy83.

I initially rejected these changes, but
* for advancement, @Arcanister pointed out that {ADVANCE_UNIT} is sometimes
  used to *downgrade* an unit. Thus, it's plausible that "advancing" can
  remove a halo.
* for killing, @newfrenchy83 said that it's *possible* (although unlikely)
  that the halo can remain. Even though I haven't reproduced the problem
  myself, it's good to ensure that the whiteboard releases its reference to
  the unit anyway.

Pull request #2028 has now been fully merged.