[Commits] [wesnoth/wesnoth] cfb2aa: AIs: idle_ai is not a "Dev AI", fixes #1955

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: cfb2aa8050216836ccef43a4fb82de5e8fdfaf79
      https://github.com/wesnoth/wesnoth/commit/cfb2aa8050216836ccef43a4fb82de5e8fdfaf79
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2017-10-04 (Wed, 04 Oct 2017)

  Changed paths:
    A data/ai/ais/idle_ai.cfg
    M data/ai/aliases/idle.cfg
    M data/ai/dev/idle_ai.cfg
    M data/ai/scenarios/scenario-AI_Arena_small.cfg

  Log Message:
  -----------
  AIs: idle_ai is not a "Dev AI", fixes #1955

As indicated in the comment of the idle_ai config file, an AI needs to
contain at least one stage, otherwise the default AI will be injected
under certain circumstances. Unlike indicated in the comment, this now
also applies to loading a mid-scenario save. (I will add that to the
comment in the next commit.)

As this AI was in data/ai/dev/, it was previously only loaded when
Wesnoth was started in debug mode. The config was thus not available
when playing in no-debug mode, causing the default AI to be injected on
reload. This caused issue #1955.

While not strictly necessary, we keep a redirect in data/ai/dev for
backward compatibility, in case the file is included in add-ons.


  Commit: f097c3d7f63b0e3b51f78a55e61afc7f77f52f30
      https://github.com/wesnoth/wesnoth/commit/f097c3d7f63b0e3b51f78a55e61afc7f77f52f30
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2017-10-04 (Wed, 04 Oct 2017)

  Changed paths:
    M data/ai/ais/idle_ai.cfg

  Log Message:
  -----------
  Idle AI: add to comment on when empty [stage] tag is needed


Compare: https://github.com/wesnoth/wesnoth/compare/9118330a308e...f097c3d7f63b