[Commits] [wesnoth/wesnoth] de5a62: Revert config unit tests to compare attributes to ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: de5a622626bda3bb5047bbac000422345fda8f65
      https://github.com/wesnoth/wesnoth/commit/de5a622626bda3bb5047bbac000422345fda8f65
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M src/tests/test_config.cpp

  Log Message:
  -----------
  Revert config unit tests to compare attributes to empty strings again

Reverts a change in commit 2eacb4e1c3c9a14d85aa1602ddc6b248441ed7fa.

The comparison in this unit test compared an *attribute* to an empty
string, not a *string*. Furthermore, the entire point of the test was
to verify that an empty attribute doesn't compare equal to the empty
string. In its old form, the test was just wrong (and failing).


  Commit: bd705671df06d80b01730908f60fe1e6831e6df6
      https://github.com/wesnoth/wesnoth/commit/bd705671df06d80b01730908f60fe1e6831e6df6
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M src/game_initialization/flg_manager.cpp
    M src/game_initialization/flg_manager.hpp
    M src/tests/test_mp_connect.cpp

  Log Message:
  -----------
  FLG manager: initially select the default faction

Turns out that this is enforced by C++ unit tests (which haven't run
successfully in Travis for a couple of months).

The tests started to fail in commit d864a89a15ee0159b28b5daec492d3070db31032 when random factions
were set to always be the first in the list
(and therefore always initially selected).


  Commit: 939ec05ab1df81d54236ca3222ad3c9151264dec
      https://github.com/wesnoth/wesnoth/commit/939ec05ab1df81d54236ca3222ad3c9151264dec
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  Travis CI: globally disable C++ unit tests

The tests haven't been run for a couple of months.
The test executable crashes on startup with the error message

Xlib: extension "RANDR" missing on display ":99.0".

After ten attempts, the test wrapper just gives up and returns success.

So, let's not even pretend that we have C++ unit tests running in Travis.
We just don't. Explicitly disabling the tests makes it more clear.


Compare: https://github.com/wesnoth/wesnoth/compare/af9862cb73a1...939ec05ab1df