[Commits] [wesnoth/wesnoth] 63cbb8: Connect Engine: cleaned up color handling a bit

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 63cbb8db73f8a829e06a94b2480041f6e803a61b
      https://github.com/wesnoth/wesnoth/commit/63cbb8db73f8a829e06a94b2480041f6e803a61b
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/game_initialization/connect_engine.cpp
    M src/game_initialization/connect_engine.hpp
    M src/gui/dialogs/multiplayer/mp_staging.cpp

  Log Message:
  -----------
  Connect Engine: cleaned up color handling a bit

* Got rid of custom color class member variable. It was no longer used except in the ctor, so it could
  be demoted to a local value.
* Use color id instead of color index for coloring unknown unit image in MP Staging.


  Commit: 3f7951fe0027a13db2905dc89a04d87e30844cc9
      https://github.com/wesnoth/wesnoth/commit/3f7951fe0027a13db2905dc89a04d87e30844cc9
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/game_initialization/connect_engine.cpp
    M src/game_initialization/connect_engine.hpp

  Log Message:
  -----------
  Connect Engine: removed "--give--" entry from controller options

This was basically used to separate players from the general controller options. In the GUI1 dialog it
was unselectable. I never got around to implementing that in the GUI2 dialog, but regardless, it doesn't
look great in the menu so I'm removing it. Plus, since the dropdowns are GUI2, we could apply different
text formatting to denote players if we wanted.


  Commit: aeb33fb7629451d4fe475586f5fa6472ba75b7c5
      https://github.com/wesnoth/wesnoth/commit/aeb33fb7629451d4fe475586f5fa6472ba75b7c5
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_create_game.cpp

  Log Message:
  -----------
  MP Create Game: remove debug mode requirement to access SP campaigns

The option to play SP campaigns in MP had been locked since support was shaky. I'm not entirely sure
how good it is currently, but games at least seem startable. This will also allow us to get more bug
reports if issues do arise, too.


  Commit: ae6ed8e713eb20cdcf81df0b2aa615077c0b6660
      https://github.com/wesnoth/wesnoth/commit/ae6ed8e713eb20cdcf81df0b2aa615077c0b6660
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_create_game.cpp

  Log Message:
  -----------
  MP Create Game: tweak game type labels


Compare: https://github.com/wesnoth/wesnoth/compare/939ec05ab1df...ae6ed8e713eb