[Commits] [wesnoth/wesnoth] cba749: GUI2/Tree View Node: store child nodes in a vector...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: cba7493494e41284ed360dbb3898ca22f8499432
      https://github.com/wesnoth/wesnoth/commit/cba7493494e41284ed360dbb3898ca22f8499432
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-12 (Tue, 12 Sep 2017)

  Changed paths:
    M src/gui/auxiliary/iterator/walker_tree_node.cpp
    M src/gui/auxiliary/iterator/walker_tree_node.hpp
    M src/gui/dialogs/gamestate_inspector.cpp
    M src/gui/widgets/tree_view.cpp
    M src/gui/widgets/tree_view_node.cpp
    M src/gui/widgets/tree_view_node.hpp

  Log Message:
  -----------
  GUI2/Tree View Node: store child nodes in a vector of unique_ptrs instead of boost::ptr_vector

I don't know if it would be better design to


  Commit: 0427e282ce05ffcd1c3787be0f497d7eb804185c
      https://github.com/wesnoth/wesnoth/commit/0427e282ce05ffcd1c3787be0f497d7eb804185c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-12 (Tue, 12 Sep 2017)

  Changed paths:
    M src/gui/dialogs/addon/manager.cpp
    M src/gui/dialogs/campaign_selection.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/widgets/multimenu_button.cpp
    M src/gui/widgets/multimenu_button.hpp

  Log Message:
  -----------
  GUI2: use MODIFIED events to handled multimenu button callbacks

Since the toggle callback already fires a NOTIFY_MODIFIED event, there's no need to have a dedicated
callback function stored in the widget instance.


  Commit: edfa7cf203e54ddccfd1a637479a005a66aa4135
      https://github.com/wesnoth/wesnoth/commit/edfa7cf203e54ddccfd1a637479a005a66aa4135
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-12 (Tue, 12 Sep 2017)

  Changed paths:
    M src/gui/dialogs/debug_clock.cpp
    M src/gui/dialogs/debug_clock.hpp
    M src/gui/dialogs/drop_down_menu.cpp
    M src/gui/dialogs/drop_down_menu.hpp
    M src/gui/dialogs/lobby/lobby.cpp
    M src/gui/dialogs/lobby/lobby.hpp
    M src/gui/dialogs/multiplayer/synced_choice_wait.cpp
    M src/gui/dialogs/multiplayer/synced_choice_wait.hpp

  Log Message:
  -----------
  GUI2/Dialogs: made use of modal_dialog::get_window over class member window pointers


  Commit: 4edb4e81146b607026ff95f270564ec3daf1d3dc
      https://github.com/wesnoth/wesnoth/commit/4edb4e81146b607026ff95f270564ec3daf1d3dc
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-12 (Tue, 12 Sep 2017)

  Changed paths:
    M src/gui/dialogs/campaign_selection.cpp

  Log Message:
  -----------
  GUI2/Campaign Selection: some formatting cleanup


  Commit: 913500aba4425d403be24e2e104a2f0e86fdf5d7
      https://github.com/wesnoth/wesnoth/commit/913500aba4425d403be24e2e104a2f0e86fdf5d7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-12 (Tue, 12 Sep 2017)

  Changed paths:
    M src/gui/widgets/tree_view_node.cpp
    M src/gui/widgets/tree_view_node.hpp

  Log Message:
  -----------
  GUI2/Tree View Node: removed ill-conceived node callback interface

When I added this back in 082fd28dc5, I apparently didn't understand how virtual functions worked.
These did *not* inherit from selectable_item and I can't even remember what they were supposed to
be for anymore (something in the GUI2 preferences dialog, perhaps). Either way, they're unused and
I could probably do something better now if the need arose.


Compare: https://github.com/wesnoth/wesnoth/compare/0fef006c6684...913500aba442