[Commits] [wesnoth/wesnoth] 2dc435: Rebuild image cache when reloading changed game co...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 2dc4352845d537634f48303c70b3cc0166af10c1
      https://github.com/wesnoth/wesnoth/commit/2dc4352845d537634f48303c70b3cc0166af10c1
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-02-06 (Tue, 06 Feb 2018)

  Changed paths:
    M src/game_config_manager.cpp
    M src/game_launcher.cpp
    M src/wesnoth.cpp

  Log Message:
  -----------
  Rebuild image cache when reloading changed game config (fixes #2424)

The above issue was caused by the fact that image::flush_cache() wasn't called after
reload_changed_game_config() when the addons manager was exited. Using F5 at the tilescreen
caused the image to appear since that callback *did* include image::flush_cache();

reload_changed_game_config() was called in 5 places, 2 of which were followed by flush_cache.
I figured it's safest to just include the latter in the former, since the other three usecases
(multiplayer installed addons before joining a game, a new core was selected, and the addons
manager was exited) all seem like places where flushing the image cache would be appropriate.